[wp-trac] [WordPress Trac] #35658: Provide additional data for registered meta through register_meta()

WordPress Trac noreply at wordpress.org
Mon Jun 27 09:11:26 UTC 2016


#35658: Provide additional data for registered meta through register_meta()
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:  jeremyfelt
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.6
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests needs-testing has-  |     Focuses:
  patch rest-api                                 |
-------------------------------------------------+-------------------------

Comment (by jeremyfelt):

 Replying to [comment:57 danielbachhuber:
 > Aside from a few smaller issues, the patch looks reasonably good after a
 first read. It needs lots of unit tests too :)

 A lot. :) Some really specific tests asserting current `register_meta()`
 behavior are also needed.

 > To possibly pre-empt some of the debate about the patch, would it be a
 good idea to produce a first draft of the dev notes for these changes,
 documenting why we're adding what we're adding now, and what developers
 can expect to see in the future? I think doing so might focus the
 conversation around whether or not the patch meets the goals of the dev
 notes.

 I agree, I think this would be helpful **and** gets us ready for dev notes
 anyway. :) If anybody would like to pick this up over the next 12 hours,
 please do. I can start on a draft later if not. I'd encourage a read of
 https://github.com/WP-API/WP-API/issues/2149, which may come close to
 explaining the "why".

 Replying to [comment:58 jipmoors]:
 > @jeremyfelt just a small naming idea, I feel `expose_to_rest` might
 better describe what it is actually for.

 I think for consistency, we need to stay aligned with
 `register_post_type()`, which uses `show_in_rest` for a similar concept.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35658#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list