[wp-trac] [WordPress Trac] #36717: Allow to access network and site properties using the current naming conventions

[WordPress Trac]

#36717: Allow to access network and site properties using the current naming
conventions
--------------------------------+------------------------
 Reporter:  flixos90            |       Owner:  flixos90
     Type:  enhancement         |      Status:  reopened
 Priority:  normal              |   Milestone:  4.6
Component:  Networks and Sites  |     Version:  4.5
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+------------------------
Changes (by flixos90):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 [attachment:36717.7.diff] fixes the problem that came up after
 [changeset:37657]. Since the properties were public before, there is an
 unserialization issue when getting cached objects as the properties are
 now private. This patch checks that the two properties have a valid value
 and otherwise queries the object again to update cache.

 This current fix makes the code of that function even more confusing to
 read, but as we will get rid of most of that code after #36935 is done
 anyway, I think it's acceptable.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36717#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform