[wp-trac] [WordPress Trac] #37172: Fix class attribute quotation
WordPress Trac
noreply at wordpress.org
Sun Jun 26 09:36:32 UTC 2016
#37172: Fix class attribute quotation
----------------------------+-----------------------------
Reporter: michalzuber | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Administration | Version:
Severity: normal | Resolution: wontfix
Keywords: | Focuses: administration
----------------------------+-----------------------------
Changes (by pento):
* status: new => closed
* version: trunk =>
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
Thank you for the patch, @michalzuber!
I'm going to close this ticket as `wontfix`, for a couple of reasons:
* Per the [https://make.wordpress.org/core/handbook/best-practices/coding-
standards/php/ WordPress Coding Standards], alternating quote style is
fine - the more important part is to not use the concatenation operator.
Variables should be evaluated in the string.
* We don't use the `PHP_EOL` constant in core at all.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37172#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list