[wp-trac] [WordPress Trac] #28314: cancel_comment_reply_link() is unflexible - respond_id & post check

WordPress Trac noreply at wordpress.org
Mon Jun 20 19:26:48 UTC 2016


#28314: cancel_comment_reply_link() is unflexible - respond_id & post check
-------------------------------------+-----------------------------
 Reporter:  Ninos Ego                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Comments                 |     Version:  3.9.1
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  template
-------------------------------------+-----------------------------
Changes (by rachelbaker):

 * keywords:  has-patch dev-feedback => has-patch needs-refresh
 * milestone:  Awaiting Review => Future Release


Comment:

 [attachment:comment-template.php.patch]  Needs a refreshed patch that also
 adheres to our code style and documentation standards.

 I suggest adding `$comment = null` as the second argument to the
 `cancel_comment_reply_link()` and `get_cancel_comment_reply_link()`
 functions so they can accept a WP_Comment object.  The
 `cancel_comment_reply_link` filter should be updated to include the
 parameter as well.  This approach wouldn't require changing the current
 function argument.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28314#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list