[wp-trac] [WordPress Trac] #37126: Shiny Updates: plugin updates fail from the update-core.php details modal

WordPress Trac noreply at wordpress.org
Sun Jun 19 14:57:01 UTC 2016


#37126: Shiny Updates: plugin updates fail from the update-core.php details modal
--------------------------+-------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.6
Component:  Plugins       |    Version:  trunk
 Severity:  normal        |   Keywords:  needs-patch
  Focuses:  javascript    |
--------------------------+-------------------------
 To reproduce, go in `update-core.php`:
 - click the "View version details" link on any available plugin update
 - the details modal opens
 - click the "Install Update Now" button
 - nothing happens, the browser console reports a JS error

 [[Image(https://cldup.com/57EOl9W2a0.png)]]

 On Firefox, the error message is a bit more clear and it says that
 `$message` is undefined.

 Quickly looking at the `updates.js` code, maybe when clicking on
 `'#plugin_install_from_iframe'` the check for the 'update-core.php' window
 parent should be reintroduced when returning early before
 `event.preventDefault()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37126>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list