[wp-trac] [WordPress Trac] #36590: POST['nav-menu-data'] breaks other POST values

[WordPress Trac]

#36590: POST['nav-menu-data'] breaks other POST values
-------------------------------------+-------------------------------------
 Reporter:  Unyson                   |       Owner:  swissspidy
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.5.3
Component:  Menus                    |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-unit-tests has-      |     Focuses:  javascript,
  patch commit fixed-major           |  administration
-------------------------------------+-------------------------------------

Comment (by swissspidy):

 In [changeset:"37750"]:
 {{{
 #!CommitTicketReference repository="" revision="37750"
 Menus: Fix `_wp_expand_nav_menu_post_data()` for PHP 5.2.

 [37748] introduced `_wp_expand_nav_menu_post_data()` together with an
 `array_replace_recursive()` compatibility function for PHP 5.2.
 Even though that compat function is tried and tested in other projects
 like BuddyPress, we need to add additional `isset()` checks in order to
 avoid 'Undefined index' notices in our case.

 See #36590.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36590#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform