[wp-trac] [WordPress Trac] #17262: wp_get_attachment_thumb_file should check new 'thumbnail' image size
WordPress Trac
noreply at wordpress.org
Sun Jun 19 11:47:48 UTC 2016
#17262: wp_get_attachment_thumb_file should check new 'thumbnail' image size
-------------------------------------------------+-------------------------
Reporter: lonnylot | Owner: joemcgill
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future
Component: Media | Release
Severity: normal | Version: 3.0
Keywords: good-first-bug needs-patch needs- | Resolution:
unit-tests | Focuses:
-------------------------------------------------+-------------------------
Changes (by swissspidy):
* keywords: good-first-bug has-patch has-unit-tests close => good-first-
bug needs-patch needs-unit-tests
* milestone: 4.6 => Future Release
Comment:
The decision in the last bug scrub in #core-images was to deprecate
`wp_get_attachment_thumb_file()` and create a replacement function that
handles both new and old data. `wp_get_attachment_image_file()` sounds
good.
`wp_get_attachment_thumb_url()` can be deprecated in favour of
`wp_get_attachment_image_url()`, which already handles the old-style
thumbnail thanks to `image_downsize()`.
I would really appreciate unit tests and some improved docs, but I don't
see that happening for 4.6.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/17262#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list