[wp-trac] [WordPress Trac] #35457: Theme installer upload button improvements

[WordPress Trac]

#35457: Theme installer upload button improvements
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.6
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots commit                 |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"37742"]:
 {{{
 #!CommitTicketReference repository="" revision="37742"
 Accessibility: Theme Installer, make the "Upload Theme" button... a
 button.

 UI controls that "do something" on a page shouldn't be links. This link
 behaves
 like a toggle to expand the uploader panel and should be a `button`
 element with
 an aria-expanded attribute. Also:

 - improves consistency with the Plugin uploader
 - keeps the themes list visible when the uploader is open
 - displays a notice when JavaScript is off
 - adds some `hide-if-no-js` CSS classes
 - removes the `themes.router.navigate()` "upload" route: seems unnecessary
 and breaks history

 Fixes #35457.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35457#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform