[wp-trac] [WordPress Trac] #35936: Add validation for Custom Structure permalinks

[WordPress Trac]

#35936: Add validation for Custom Structure permalinks
-------------------------------------------------+-------------------------
 Reporter:  SteveNetRivet                        |       Owner:  swissspidy
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
Component:  Permalinks                           |  Release
 Severity:  normal                               |     Version:
 Keywords:  good-first-bug has-patch has-unit-   |  Resolution:
  tests                                          |     Focuses:  ui
-------------------------------------------------+-------------------------

Comment (by swissspidy):

 What seems like an easy task has once again proven to be quite a mess…

 [attachment:35936.4.diff] adds the translator comment and keeps the
 redirect in any case. Since `sanitize_option()` relies on
 `add_settings_error()` I had to rewrite the whole message handling to use
 `add_settings_error()` / `get_settings_errors()`. That's why the diff
 looks so huge, when it basically only brings `options-permalink.php` in
 line with the rest of the admin using the settings API.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35936#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform