[wp-trac] [WordPress Trac] #29154: plugin_basename() doesn't normalize the file path before unresolving symlinks

[WordPress Trac]

#29154: plugin_basename() doesn't normalize the file path before unresolving
symlinks
--------------------------------------+----------------------
 Reporter:  jdgrimes                  |       Owner:  ocean90
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  4.6
Component:  Plugins                   |     Version:  3.9
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:6 ocean90]:
 > [attachment:29154.3.diff] includes a unit test which fails without the
 change to `plugin_basename()`

 For reference, the test still failed on my install after [37332]:
 {{{
 1)
 Tests_Plugin_Basename::test_should_return_correct_basename_for_symlinked_plugins
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -a-symlinked-plugin/plugin.php
 +S:\home\wordpress\develop/src/wp-content/plugins/a-symlinked-
 plugin/plugin.php
 }}}

 [37719] fixes that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29154#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform