[wp-trac] [WordPress Trac] #36944: Display server-sent Customizer setting validation errors before save is attempted
WordPress Trac
noreply at wordpress.org
Tue Jun 14 19:16:57 UTC 2016
#36944: Display server-sent Customizer setting validation errors before save is
attempted
---------------------------------------------+--------------------------
Reporter: westonruter | Owner: westonruter
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.6
Component: Customize | Version: trunk
Severity: normal | Resolution: fixed
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+--------------------------
Changes (by westonruter):
* status: accepted => closed
* resolution: => fixed
Comment:
In [changeset:"37700"]:
{{{
#!CommitTicketReference repository="" revision="37700"
Customize: Update server-sent setting validation notifications as changes
are entered.
Send back setting validities with full refreshes and selective refreshes
so that invalid settings can have notifications displayed immediately
before attempting save, and so that these notifications can be cleared as
soon as the input is corrected.
* Splits out JS logic for listing controls into separate methods
`wp.customize.Setting.prototype.findControls()` and
`wp.customize.findControlsForSettings()`.
* Adds a `setting` property to the `data` on notifications added to
controls that are synced from their settings.
* Adds `selective-refresh-setting-validities` message sent from preview to
pane.
* Changes `WP_Customize_Manager::validate_setting_values()` to return when
settings are valid as well as invalid.
* Adds `WP_Customize_Manager::prepare_setting_validity_for_js()`.
* Add setting validities to data exported to JS in Customizer Preview and
in selective refresh responses.
Fixes #36944.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36944#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list