[wp-trac] [WordPress Trac] #34936: Reconcile wp-settings-cli.php with wp-settings.php

[WordPress Trac]

#34936: Reconcile wp-settings-cli.php with wp-settings.php
---------------------------------+-----------------------
 Reporter:  danielbachhuber      |       Owner:  jorbin
     Type:  enhancement          |      Status:  assigned
 Priority:  normal               |   Milestone:  4.6
Component:  Bootstrap/Load       |     Version:
 Severity:  normal               |  Resolution:
 Keywords:  wp-cli dev-feedback  |     Focuses:
---------------------------------+-----------------------
Changes (by jorbin):

 * keywords:  wp-cli has-patch commit => wp-cli dev-feedback


Comment:

 I reverted to `enable_maintenance_mode` since the dropin is only a small
 part and this actually has no effect specificly on the dropin. Otherwise,
 thanks @DrewAPicture and @ocean90.


 The final piece that we need to do is to add in the new action that
 @danielbachhuber's
 [https://core.trac.wordpress.org/attachment/ticket/34936/shortinit.34936.1.diff
 patch] suggests.  I'm not sure I like the name `shortinit` for the action.
 The purpose of the action as descibed in one of the
 [https://wordpress.slack.com/messages/cli/search/shortinit/ linked chats]
 is to provide a place to `address $wpdb->error, APC cache check, and
 wp_not_installed()`.

 I'm not sure the best name for it. I'm thinking `pre_shortinit_check` but
 would love to know others ideas.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34936#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform