[wp-trac] [WordPress Trac] #34936: Reconcile wp-settings-cli.php with wp-settings.php

[WordPress Trac]

#34936: Reconcile wp-settings-cli.php with wp-settings.php
-------------------------------------------+-----------------------
 Reporter:  danielbachhuber                |       Owner:  jorbin
     Type:  enhancement                    |      Status:  assigned
 Priority:  normal                         |   Milestone:  4.6
Component:  Bootstrap/Load                 |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  dev-feedback wp-cli has-patch  |     Focuses:
-------------------------------------------+-----------------------

Comment (by DrewAPicture):

 Replying to [comment:29 ocean90]:
 > [attachment:34936.4.diff] looks good so far. I'd only change
 `enable_maintenance_mode_checks` to `enable_maintenance_mode` since there
 are no checks after this filter.

 Good call. I completely glossed over the fact that maintenance.php is
 ''not'' in fact a core file (heh), but a drop-in.

 See [attachment:34936.5.diff], where I've adjusted the summary for the
 maintenance hook to match the style of the hook summary for advanced-
 cache.php. I also standardized the hook names for the drop-ins:

 * `enable_loading_maintenance_dropin`
 * `enable_loading_advanced_cache_dropin`

 I think that makes things pretty clear.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34936#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform