[wp-trac] [WordPress Trac] #36168: Introduce get_canonical_url function
WordPress Trac
noreply at wordpress.org
Fri Jun 10 21:29:46 UTC 2016
#36168: Introduce get_canonical_url function
--------------------------------------+------------------------
Reporter: joostdevalk | Owner: ocean90
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 4.6
Component: Canonical | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------
Comment (by ocean90):
@joostdevalk, @jipmoors: Thanks for your patches. [attachment:36168.patch]
is a refresh and includes following changes:
* Name of function should start with `wp_`: `wp_get_canonical_url()`
* Removes the default argument for `get_permalink()`
* Docs tweaks
* Tests: Use shared test fixture
* Tests: Use `WP_UnitTestCase::go_to()` and
`WP_UnitTestCase::set_permalink_structure()`
* Tests: Move test class to the /link/ directory
Let me know what you think.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36168#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list