[wp-trac] [WordPress Trac] #36717: Allow to access network and site properties using the current naming conventions

[WordPress Trac]

#36717: Allow to access network and site properties using the current naming
conventions
-------------------------------------+------------------------
 Reporter:  flixos90                 |       Owner:  flixos90
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.6
Component:  Networks and Sites       |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  multisite
-------------------------------------+------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch => has-patch needs-testing
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This broke things on w.org last night, and needs some more exploration.

 From @dd32 [https://wordpress.slack.com/archives/core/p1465365335000649 in
 Slack]:

 > "When you `serialize()` a object which has public properties, and
 `unserialize()` that same string later when the object has a private
 property, the public property gets set which overrides any `__get()`
 methods."

 Full `WP_Site` objects with existing public properties were stored in
 cache via `get_blog_details()`, which was being used along with the
 `pre_get_site_path` filter. There will be other sites doing something
 similar.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36717#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform