[wp-trac] [WordPress Trac] #33055: Support Parallel HTTP Requests in WP_Http, et al
WordPress Trac
noreply at wordpress.org
Tue Jun 7 20:07:15 UTC 2016
#33055: Support Parallel HTTP Requests in WP_Http, et al
----------------------------------------+--------------------------
Reporter: wonderboymusic | Owner: rmccue
Type: task (blessed) | Status: assigned
Priority: high | Milestone: 4.6
Component: HTTP API | Version:
Severity: normal | Resolution:
Keywords: needs-patch needs-dev-note | Focuses: performance
----------------------------------------+--------------------------
Comment (by mnelson4):
> Regarding this introduction, it would probably be a good idea to inform
developers that they should no longer be explicitly checking for an array
from the wp_remote_* functions. Casting the result of the wp_remote_*
calls will also fail.
+1. This change isn't exactly 100% backwards compatible so it might be
good to bring this more to the community's attention.
This just broke our plugin's paypal integration because we had an
`is_array($response)` check (which just needs to be changed to
`is_array($response) || $response instanceof ArrayAccess`). Glad we caught
this before 4.6 got released, hopefully we can push a fix to our plugins
and have all our users update before they update WP core to 4.6 because
then it will break for them on live too.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33055#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list