[wp-trac] [WordPress Trac] #34905: zxcvbn() not defined (and making it impossible to edit an existing user)

[WordPress Trac]

#34905: zxcvbn() not defined (and making it impossible to edit an existing user)
-----------------------------------+------------------------------
 Reporter:  wp-plugin@…            |       Owner:  adamsilverstein
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.6
Component:  Users                  |     Version:  4.3.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  javascript
-----------------------------------+------------------------------
Changes (by adamsilverstein):

 * owner:  peterwilsoncc => adamsilverstein


Comment:

 Hi @peterwilsoncc; thanks for the patch.

 I tested this using the steps you described and was able to reproduce the
 issue and verify it is fixed nicely by your patch. I think your approach
 is sound, however I only tested the patch in Chrome; before this is
 committed, I think we should perform some additional testing across
 browsers/devices (including ie8 :( )

 Here is a screencast showing the console errors when interacting before
 the patch:

 http://cl.ly/122c1y1x2w3O

 Here is a screencast showing the process after the patch is applied; the
 field still works and there is no error:

 http://cl.ly/123E1h3M0S3E

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34905#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform