[wp-trac] [WordPress Trac] #36615: Avoid PHP notices when trying to update translations which are already up to date

[WordPress Trac]

#36615: Avoid PHP notices when trying to update translations which are already up
to date
-----------------------------+----------------------
 Reporter:  ocean90          |       Owner:  ocean90
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  4.6
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:  fixed
 Keywords:  needs-patch      |     Focuses:
-----------------------------+----------------------
Changes (by ocean90):

 * owner:   => ocean90
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"37635"]:
 {{{
 #!CommitTicketReference repository="" revision="37635"
 Upgrader: Don't use `Language_Pack_Upgrader_Skin::before()` and
 `Language_Pack_Upgrader_Skin::after()` when translations are up to date.

 Avoids a PHP notice since `Language_Pack_Upgrader_Skin::before()` tries to
 access a non-existent update.
 Also, change the `up_to_date` string to use the plural form because
 translations are only updated in bulk mode.

 Fixes #36615.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36615#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform