[wp-trac] [WordPress Trac] #37032: Guard against infinite reload when setting change causes premature selective refresh
WordPress Trac
noreply at wordpress.org
Sun Jun 5 06:24:30 UTC 2016
#37032: Guard against infinite reload when setting change causes premature
selective refresh
--------------------------+-----------------
Reporter: westonruter | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.6
Component: Customize | Version: 4.5
Severity: normal | Keywords:
Focuses: |
--------------------------+-----------------
If a setting gets set to a value in JS that is different than the
sanitized JS-value exported from PHP, then best case there can be an extra
refresh for a partial in the preview, and worse case (if the partial has
to fallback to full refresh) there can be an infinite reload in the
Customizer preview. The reason for the issue is that selective refresh is
currently allowing partial refreshes to be triggered before the settings
are `sync`'ed from the pane to the preview. The fix is to just prevent
setting changes from causing a refresh until the `active` message has been
sent from the pane to the preview.
Originally reported at https://github.com/xwp/wp-customize-posts/pull/163
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37032>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list