[wp-trac] [WordPress Trac] #34936: Reconcile wp-settings-cli.php with wp-settings.php

[WordPress Trac]

#34936: Reconcile wp-settings-cli.php with wp-settings.php
-------------------------------------------+------------------
 Reporter:  danielbachhuber                |       Owner:
     Type:  enhancement                    |      Status:  new
 Priority:  normal                         |   Milestone:  4.6
Component:  Bootstrap/Load                 |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  dev-feedback wp-cli has-patch  |     Focuses:
-------------------------------------------+------------------
Description changed by danielbachhuber:

Old description:

> WP-CLI uses a custom wp-settings-cli.php to load WordPress, instead of
> wp-settings.php. While I appreciate the [http://wp-cli.org/blog/how-wp-
> cli-loads-wordpress.html historical justifications] for the bootstrap
> process, it would be much better if WP-CLI could use wp-settings.php
> because, occasionally, there are [http://wp-
> cli.org/blog/versions-0.21.1-and-0.20.4.html substantial problems]
> arising from needing to maintain a fork.
>
> Before we can deprecate wp-settings-cli.php though, we'll need to
> reconcile the modifications made to the bootstrap process. I've
> [https://github.com/danielbachhuber/wordpress-develop/pull/2/files put
> together a branch] to compare the current differences.
>
> Here's a summary:
>
> * [ ] Core: Provide a way of forcefully bypassing `wp_maintenance()` so
> that WP-CLI can continue to operate when `.maintenance` exists.
> * [x] WP-CLI: Load `WP_CLI\Utils` just before wp-settings.php is called,
> instead of in wp-settings-cli.php. [https://github.com/wp-cli/wp-
> cli/pull/2277 #wp-cli-2277]
> * [ ] Core: Provide a way of overloading `wp_debug_mode()`, which isn't
> called at all in wp-settings-cli.php.
> * [ ] Core: Provide a way of forcefully skipping loading `wp-content
> /advance-cache.php`, which historically has caused problems with WP-CLI.
> * [ ] Core: Provide one or more hooks to make runtime modifications
> before and after `require_wp_db()` is called, and after
> `wp_start_object_cache()` is called. Will need further discovery and
> testing.
> * [ ] Core: Provide a way of overloading `wp_not_installed()`, which
> outputs headers and can call `die()`
> * [ ] Core: Provide a way to skip the loading of specific plugins and/or
> themes.
> * [ ] Address how we should handle WP-CLI's current exclusion of `wp-
> includes/vars.php`
>
> We can split these into sub-tickets as the discussion evolves. I look
> forward to the feedback.

New description:

 WP-CLI uses a custom wp-settings-cli.php to load WordPress, instead of wp-
 settings.php. While I appreciate the [http://wp-cli.org/blog/how-wp-cli-
 loads-wordpress.html historical justifications] for the bootstrap process,
 it would be much better if WP-CLI could use wp-settings.php because,
 occasionally, there are [http://wp-
 cli.org/blog/versions-0.21.1-and-0.20.4.html substantial problems] arising
 from needing to maintain a fork.

 Before we can deprecate wp-settings-cli.php though, we'll need to
 reconcile the modifications made to the bootstrap process. I've
 [https://github.com/danielbachhuber/wordpress-develop/pull/2/files put
 together a branch] to compare the current differences.

 Here's a summary:

 * [ ] Core: Provide a way of forcefully bypassing `wp_maintenance()` so
 that WP-CLI can continue to operate when `.maintenance` exists.
 * [x] WP-CLI: Load `WP_CLI\Utils` just before wp-settings.php is called,
 instead of in wp-settings-cli.php. [https://github.com/wp-cli/wp-
 cli/pull/2277 #wp-cli-2277]
 * [ ] Core: Provide a way of overloading `wp_debug_mode()`, which isn't
 called at all in wp-settings-cli.php.
 * [ ] Core: Provide a way of forcefully skipping loading `wp-content
 /advance-cache.php`, which historically has caused problems with WP-CLI.
 * [ ] Core: Provide one or more hooks to make runtime modifications before
 and after `require_wp_db()` is called, and after `wp_start_object_cache()`
 is called. Will need further discovery and testing.
 * [ ] Core: Provide a way of overloading `wp_not_installed()`, which
 outputs headers and can call `die()`
 * [x] Core: Provide a way to skip the loading of specific plugins and/or
 themes.
 * [x] Address how we should handle WP-CLI's current exclusion of `wp-
 includes/vars.php`

 We can split these into sub-tickets as the discussion evolves. I look
 forward to the feedback.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34936#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform