[wp-trac] [WordPress Trac] #36960: Add filter to maintenance_mode() function for $maintenance_string
WordPress Trac
noreply at wordpress.org
Thu Jun 2 22:36:01 UTC 2016
#36960: Add filter to maintenance_mode() function for $maintenance_string
-------------------------------------+------------------------------
Reporter: amandato | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Upgrade/Install | Version: 4.5.2
Severity: normal | Resolution:
Keywords: reporter-feedback close | Focuses:
-------------------------------------+------------------------------
Changes (by ocean90):
* keywords: => reporter-feedback close
Comment:
Why would someone want to change that string?
Snippet from `wp_maintenance()`:
{{{
global $upgrading;
include( ABSPATH . '.maintenance' );
// If the $upgrading timestamp is older than 10 minutes, don't die.
if ( ( time() - $upgrading ) >= 600 )
return;
}}}
----
[attachment:class-wp-upgrader.diff] is a bit broken. The patch should
include the full path and the filename. Also, filters need to be
documented as per the [https://make.wordpress.org/core/handbook/best-
practices/inline-documentation-standards/php/#4-hooks-actions-and-filters
documentation standards].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36960#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list