[wp-trac] [WordPress Trac] #36944: Display server-sent Customizer setting validation errors before save is attempted

WordPress Trac noreply at wordpress.org
Wed Jun 1 17:41:59 UTC 2016


#36944: Display server-sent Customizer setting validation errors before save is
attempted
------------------------------------------+--------------------------
 Reporter:  westonruter                   |       Owner:  westonruter
     Type:  defect (bug)                  |      Status:  accepted
 Priority:  normal                        |   Milestone:  4.6
Component:  Customize                     |     Version:  trunk
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:
------------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:   => needs-unit-tests needs-patch
 * owner:   => westonruter
 * status:  new => accepted


Comment:

 In [attachment:36944.0.wip.diff]:

 * Send back all validities for all settings, not just the error
 notifications for invalid settings.
 * Explicitly link a control notification to its corresponding setting.
 * Keep track of which notifications are from the server versus which are
 created in JS.
 * Prevent submitting settings if there are validity errors that are not
 from the server.
 * Skip removing all notification errors at save, only removing errors if
 they are absent from the subsequent save response.
 * Add `wp.customize.findControlsForSettings( settingIds )` helper.

 What is next is to make sure the setting validity check are done during
 full refresh and partial refresh requests, and sent back to the Customizer
 as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36944#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list