[wp-trac] [WordPress Trac] #37495: Restore `install_plugins_upload` action to allow replacing plugin upload form

[WordPress Trac]

#37495: Restore `install_plugins_upload` action to allow replacing plugin upload
form
-------------------------------------------+-----------------------------
 Reporter:  DavidAnderson                  |       Owner:  ocean90
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  4.6
Component:  Plugins                        |     Version:  trunk
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed  |     Focuses:  administration
-------------------------------------------+-----------------------------
Changes (by ocean90):

 * owner:   => ocean90
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38172"]:
 {{{
 #!CommitTicketReference repository="" revision="38172"
 Plugins: Use `install_plugins_upload` action to print the upload form.

 Since [37221] the upload form is added to every plugin install screen via
 `install_plugins_upload()`. Previously the form was added through the
 `install_plugins_upload` (alias of `install_plugins_$tab`) action which
 allowed plugin authors to replace the form. This restores the previous
 behaviour.

 * Add the form only to non-upload plugin install screens.
 * Replace `install_plugins_upload()` with the `install_plugins_upload` and
 `install_plugins_pre_upload` actions.
 * Remove `$upload_tab_class` and add a CSS class for the current tab to
 `.wrap`
 * Adjust CSS selectors and toggle the whole container to support upload
 without an `upload-plugin` class.

 Props DavidAnderson, ocean90.
 Fixes #37495.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37495#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform