[wp-trac] [WordPress Trac] #37510: Shiny Updates: consider to improve the bulk update failure notices

[WordPress Trac]

#37510: Shiny Updates: consider to improve the bulk update failure notices
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Plugins                  |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots shiny-   |     Focuses:  ui, accessibility,
  updates has-patch reporter-        |  javascript
  feedback                           |
-------------------------------------+-------------------------------------

Comment (by afercia):

 @juhise @Ankit K Gupta thanks very much the approach looks good. I'd
 recommend a few things:
 - the `%s failure` (singular and plural) string should be improved a bit;
 to keep it simple, maybe there's no need to distinguish between plugins
 and themes
 - this should be translatable: `<span class="screen-reader-text">Toggle
 panel: Failure Notice</span>`
 - the patch should use some [https://make.wordpress.org/core/handbook
 /best-practices/coding-standards/ coding standards], mainly about braces
 and spaces; also, WordPress uses tabs for indentation and not spaces, this
 has probbly something to do with some settings in the editor you're using
 - the if/else to toggle the `aria-expanded` value maybe could be avoided
 and use just the value of `$bulkActionNotice.find( 'ul' ).hasClass(
 'hidden' )` which already returns true or false
 - jQuery optimisation: instead of getting the same elements multiple
 times, I'd get them once and store them in a variable for later reuse

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37510#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform