[wp-trac] [WordPress Trac] #37494: Proxy authentication is ignored by Requests
WordPress Trac
noreply at wordpress.org
Sat Jul 30 07:37:43 UTC 2016
#37494: Proxy authentication is ignored by Requests
------------------------------+------------------------
Reporter: francescobagnoli | Owner: dd32
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 4.6
Component: HTTP API | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+------------------------
Comment (by dd32):
I personally prefer branching and not doing it conditionally like this, so
[attachment:37494.3.patch] is how I'd personally do it (although it needs
to remove the first `$options['proxy'] = new ..`).
However, as @rmccue notes, `use_authentication` (along with `user` and
`pass`) are public and so a valid approach and consistent with the
existing code, so [attachment:37494.2.patch] also has my +1 for commit
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37494#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list