[wp-trac] [WordPress Trac] #37512: WC 4.6 RC 1 - missing JS triggers in Shiny Updates / Deletes

WordPress Trac noreply at wordpress.org
Fri Jul 29 10:03:13 UTC 2016

#37512: WC 4.6 RC 1 - missing JS triggers in Shiny Updates / Deletes
 Reporter:  DavidAnderson               |      Owner:
     Type:  defect (bug)                |     Status:  new
 Priority:  normal                      |  Milestone:  Awaiting Review
Component:  Upgrade/Install             |    Version:  trunk
 Severity:  normal                      |   Keywords:
  Focuses:  javascript, administration  |
 In #37216, triggers were added to Shiny Updates to enable the existing
 functionality of our plugin to continue working with the changed theme
 update implementation. (Our plugin pops up a dialog, communicates with the
 back-end via AJAX to perform a backup of the site's themes, and then when
 the backup is complete hands back control so that the update proceeds).

 Further testing has revealed another issue - the "Shiny Deletes" for
 plugins or themes don't work with our plugin active, and there's no way
 for us to hook in to make it work.

 The cause is the lack of an analogous trigger on the deletion event
 (corresponding to the existing triggers on the update event).

 The attached patch adds triggers upon plugin and theme deletion. It also
 adds triggers in the corresponding location upon plugin and theme install;
 we don't use that, but it ought to be there for completeness and to allow
 other plugin authors to hook in.

Ticket URL: <https://core.trac.wordpress.org/ticket/37512>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list