[wp-trac] [WordPress Trac] #37488: Improve output buffering when used for request_filesystem_credentials()

[WordPress Trac]

#37488: Improve output buffering when used for request_filesystem_credentials()
----------------------------+----------------------
 Reporter:  ocean90         |       Owner:  ocean90
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  4.6
Component:  Filesystem API  |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:
----------------------------+----------------------
Changes (by ocean90):

 * owner:   => ocean90
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38167"]:
 {{{
 #!CommitTicketReference repository="" revision="38167"
 Filesystem API: Output buffering for `request_filesystem_credentials()`
 should wrap the function directly.

 Previously `ob_end_clean()` was only called when the previous condition
 was successful which led to unexpected results when another output
 buffering was involved, like PHPUnit's.

 Fixes #37488.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37488#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform