[wp-trac] [WordPress Trac] #37437: Requests_Cookie::parse() unable to parse WP_Http_Cookie object coming from WP_Http::request()

WordPress Trac noreply at wordpress.org
Wed Jul 27 15:31:49 UTC 2016


#37437: Requests_Cookie::parse() unable to parse WP_Http_Cookie object coming from
WP_Http::request()
--------------------------------------+---------------------
 Reporter:  stephdau                  |       Owner:  rmccue
     Type:  defect (bug)              |      Status:  closed
 Priority:  high                      |   Milestone:  4.6
Component:  HTTP API                  |     Version:  trunk
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+---------------------
Changes (by ocean90):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38164"]:
 {{{
 #!CommitTicketReference repository="" revision="38164"
 HTTP API: Normalize cookies before passing them to Requests.

 Requests has its own cookie object in form of `Requests_Cookie`. Therefore
 we have to convert `WP_Http_Cookie` objects to `Requests_Cookie`.
 This introduces `WP_Http_Cookie::get_attributes()` to retrieve cookie
 attributes of a `WP_Http_Cookie` object and `WP_Http::normalize_cookies()`
 to convert the cookie objects.

 Fixes #37437.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37437#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list