[wp-trac] [WordPress Trac] #37470: Shiny Updates: Erroneous Plugin Deactivation

[WordPress Trac]

#37470: Shiny Updates: Erroneous Plugin Deactivation
----------------------------+-----------------------
 Reporter:  voldemortensen  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.6
Component:  Plugins         |     Version:  4.2.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------

Comment (by Otto42):

 No, the `wp_ajax_update_plugin()` function can only update a single plugin
 anyway, because of code earlier in the function. It has to be passed a
 plugin path and a slug through `$_POST`.

 I suspect that the `Automatic_Upgrader_Skin` class is the main problem
 here, as it doesn't have any support for re-activating the plugin
 afterwards like the `Plugin_Upgrader_Skin` class does, so calling the
 normal `::upgrade()` would always deactivate the plugin silently, while
 `::bulk_upgrade()` would only deactivate the plugin in this special
 circumstance.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37470#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform