[wp-trac] [WordPress Trac] #36638: Detect broken URLs in the editor
WordPress Trac
noreply at wordpress.org
Tue Jul 26 02:07:59 UTC 2016
#36638: Detect broken URLs in the editor
-------------------------------------------------+-------------------------
Reporter: iseulde | Owner: azaozz
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 4.6
Component: Editor | Version:
Severity: normal | Resolution:
Keywords: needs-unit-tests needs-testing | Focuses: ui
needs-patch |
-------------------------------------------------+-------------------------
Comment (by dd32):
I'd just like to voice an opinion that performing a HTTP request to
"validate" each URL isn't likely to be very workable in the long run.
The scenario's that I'm looking at are things like..
- Editors may have a URL which is currently 403/404 which they wish to
have in a draft, causing them to just ignore those notifications all the
time
- Linking to sites which intentionally block, or rate limit the WordPress
UA would incorrectly fail (Leading to a bad user experience and inability
to trust it going forward)
- The link would be marked inaccessible for sites which are temporarily
unavailable, slow, or inaccessible from the servers network
- The WordPress UA might get rate limited or blocked on more
sites/networks for being seen as making a lot of irrelevant requests. We
already see this happening with blocking of the WordPress UA (as noted
above) due to the XML-RPC attacks.
If the HTTP request is kept, then
- a HEAD should be performed instead IMHO
- The `limit_response_size` parameter should be set to avoid issues when
linking to large documents.
- The `Relative URL` handling could probably use
`WP_HTTP::make_absolute_url()`
Personally I feel that anything more than a regular expression is probably
overkill here for the limited benefit it provides.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36638#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list