[wp-trac] [WordPress Trac] #36827: Regular expression in wp_guess_url() is slightly too permissive.
WordPress Trac
noreply at wordpress.org
Mon Jul 25 02:10:05 UTC 2016
#36827: Regular expression in wp_guess_url() is slightly too permissive.
-------------------------------------------------+-------------------------
Reporter: cfinke | Owner: curdin
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: Future
Component: General | Release
Severity: normal | Version: 3.4
Keywords: has-patch good-first-bug has-unit- | Resolution:
tests | Focuses:
-------------------------------------------------+-------------------------
Changes (by netweb):
* owner: => curdin
* status: new => assigned
Comment:
Assigning the ticket to mark the ''good-first-bug'' as "claimed".
Replying to [comment:10 curdin]:
> This is my first core patch, please let me know if I don't follow some
convention ;)
@curdin Thanks for the patch :)
In the future you should add a file extension to the filename, e.g.
`36827.diff`, this makes the patch more easily read here in Trac, e.g. you
see the red and green diff highlights when viewing
[attachment:wp_guess_url_regex.patch] but not
[attachment:36827_guess_url_patch_and_test] ;)
See
https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36827#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list