[wp-trac] [WordPress Trac] #37233: Shiny Updates: "Add New Plugin" shiny search issues

[WordPress Trac]

#37233: Shiny Updates: "Add New Plugin" shiny search issues
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  swissspidy
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots shiny-   |     Focuses:  ui, accessibility,
  updates has-patch needs-refresh    |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots shiny-updates has-patch => has-screenshots
     shiny-updates has-patch needs-refresh


Comment:

 Quickly tested the last patch, and the history works nicely. However,
 needs to take into account that the search term can be made of more than
 just one word.

 Add new plugin search:

 [[Image(https://cldup.com/Bfh7BRV9sy.png)]]

 Installed plugins search:

 [[Image(https://cldup.com/1gafpa0_Jh.png)]]

 When navigating back, the search field gets updated with the search string
 and `urlSearchString` needs to be decoded and also to replace any plus
 sign with a space. About the "sub title" thing added to the page heading,
 I'd be in favour of removing it entirely as noted also in an inline
 comment :)
 `// Can we just ditch this whole subtitle business?`.
 See also #26601.

 Lastly, and unrelated to the last patch: the `change` event on the search
 type select can be confusing for users and not ideal for accessibility
 since it fires in different ways across different browsers/platforms. For
 the same reason, a similar change was reverted in #31634 but to be honest
 I wouldn't know how to solve this issue in this context, since there's no
 submit button.

 Minor: coding standards and variables declaration/assignment could be
 improved a bit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37233#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform