[wp-trac] [WordPress Trac] #37233: Shiny Updates: "Add New Plugin" shiny search issues

WordPress Trac noreply at wordpress.org
Fri Jul 22 08:45:07 UTC 2016

#37233: Shiny Updates: "Add New Plugin" shiny search issues
 Reporter:  afercia                  |       Owner:  swissspidy
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots shiny-   |     Focuses:  ui, accessibility,
  updates has-patch                  |  javascript

Comment (by swissspidy):

 Thanks for your patch @rahulsprajapati!

 Unfortunately I don't have much time to work on this so here are some

 * Instead of doing stuff like `bodyElem.hasClass( "plugin-install-php" )`,
 we should check the global `pagenow` variable
 * Instead of triggering `input` events, we should put the search handling
 in a separate function and call that function. That way it's also better
 * What about the dropdown? That should be handled in the `popstate`
 callback too.
 * `wp.urlParam` looks interesting. Definitely needs unit tests though.

Ticket URL: <https://core.trac.wordpress.org/ticket/37233#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list