[wp-trac] [WordPress Trac] #26350: !important audit

WordPress Trac noreply at wordpress.org
Thu Jul 21 21:24:14 UTC 2016


#26350: !important audit
----------------------------+------------------------------
 Reporter:  azaozz          |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  high            |   Milestone:  Future Release
Component:  Administration  |     Version:  3.8
 Severity:  major           |  Resolution:
 Keywords:  needs-testing   |     Focuses:  ui, performance
----------------------------+------------------------------

Comment (by adamsilverstein):

 @FolioVision Thanks for your offer of help.

 Essentially we need to go thru each use of `!important` and see how its
 being used, try removing it and determine any consequences, then remove
 any that can be and document the reason for the remaining uses.

 Using svn or git blame type tools we should be able to track the commit
 that introduced each usage (although this may be difficult given the
 wholesale restructure the css has undergone in the past); alternately
 using inspection and code hunting we should be able to determine where the
 class in question is used and possibly determine why it was added. Its
 possible many are useful (since we strive to support older browsers), or
 that they are extraneous - I really don't know.

 My farcical proposal was just to 'remove them all' and see what breaks but
 in reality we probably need to exercise more diligence. If we can't
 determine a purpose in each case I think we should remove them and see
 what breaks, however we still need to spend some time trying to determine
 why they were added. Where we do determine they have a purpose we should
 add some inline comments in the CSS to indicate why the use is required or
 desired.

 I know this is a somewhat tedious task, however its something we really
 should undertake and we can take them out little by little so don't feel
 like you have to check them all to contribute.

 Thanks again for your offer of assistance.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26350#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list