[wp-trac] [WordPress Trac] #36638: Detect broken URLs in the editor

WordPress Trac noreply at wordpress.org
Wed Jul 20 22:17:29 UTC 2016

#36638: Detect broken URLs in the editor
 Reporter:  iseulde                         |       Owner:  azaozz
     Type:  task (blessed)                  |      Status:  assigned
 Priority:  normal                          |   Milestone:  4.6
Component:  Editor                          |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  needs-unit-tests needs-testing  |     Focuses:  ui

Comment (by azaozz):

 > some ISPs redirect to a "courtesy page" (for marketing purposes!) when
 you request a not existent URL.
 > I'm afraid there's no much we can do here other than blaming bad ISPs
 practices :(

 Yes, actually most ISPs do that now (AFAIK). Yet another reason the URL
 test will fail. If we don't follow the redirect, the response will be
 "undecided", if we follow it, we get 200. In both cases we don't flag the
 URL as "bad".

 > I'm not sure I understand the checks for visible() for example in
 setLinkError() where toolbar.visible() is always false for me.

 `setLinkError()` is used in two places: one is after a regex check for
 well formed URL. As that is very fast, the `toolbar.visible()` will always
 be false. The other is after the AJAX response. The toolbar will usually
 be visible there depending on how long the AJAX takes (if it's very very
 fast, it may not be visible yet).

 36638.8.patch looks good. Going to commit it now to get the accessibility
 improvements in.

Ticket URL: <https://core.trac.wordpress.org/ticket/36638#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list