[wp-trac] [WordPress Trac] #12922: Setting featured image does not require the post to be saved
WordPress Trac
noreply at wordpress.org
Wed Jul 20 04:57:13 UTC 2016
#12922: Setting featured image does not require the post to be saved
-----------------------------+-----------------------
Reporter: rooodini | Owner: flixos90
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.6
Component: Post Thumbnails | Version: 3.0
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-----------------------------+-----------------------
Comment (by joemcgill):
Replying to [comment:28 flixos90]:
> After having thought about and tested both implementations, I think we
should rather go with the latter for now. While it is more a workaround
than an actual solution, we can still change it when we actually start
supporting revision meta at some point (see #20299). The first approach
works as well, but I'm not really fond of using revision meta for this
change before we generally open it up, especially since this would include
adding all these exceptions for the _thumbnail_id meta key.
I had the same reservations about adding exceptions for `_thumbnail_id` to
revision post meta when I was looking over the two approaches. The
approach to use query variables for previews in [attachment:12922.6.diff]
definitely feels like a workaround to me, but is a decent improvement
until there is a better approach for handling revision post meta, because
it gives people the ability to preview featured image changes on published
posts without accidentally updating the post.
Previewing changes to drafts still seems to save any changes to the
featured image, but I think it's fine to leave that behavior since the
goal here is to keep someone from accidentally changing the image of their
published post without realizing it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/12922#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list