[wp-trac] [WordPress Trac] #37409: Broken & illogic conditional check in wp_get_document_title()

WordPress Trac noreply at wordpress.org
Tue Jul 19 14:42:25 UTC 2016


#37409: Broken & illogic conditional check in wp_get_document_title()
--------------------------+------------------------------
 Reporter:  ReneHermi     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  4.5.3
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by achbed):

 Is this check for is_home even needed, since we should have already
 covered all applicable cases with the `is_front_page()` and
 `is_post_type_archive()` checks above that?  There's no harm in leaving it
 in, but the optimizer in me says unit test this and remove if it causes no
 change.  An electron saved is an electron earned :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37409#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list