[wp-trac] [WordPress Trac] #37233: Shiny Updates: "Add New Plugin" shiny search issues

[WordPress Trac]

#37233: Shiny Updates: "Add New Plugin" shiny search issues
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  swissspidy
     Type:  defect (bug)             |      Status:  assigned
 Priority:  high                     |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-screenshots shiny-   |     Focuses:  ui, accessibility,
  updates has-patch                  |  javascript
-------------------------------------+-------------------------------------

Comment (by adamsilverstein):

 Nice work here @afercia identifying these bugs and clearly describing how
 to reproduce them! I tested the latest patch and verified it resolved the
 issues raised, thanks @swissspidy.

 [attachment:37233.3.diff] builds on .2 and adds the following:

 * switch the event from `search` to the standard `input` as suggested by
 @afercia and as used for the installed plugin search (and elsewhere in
 core JS). I am not certain we need keyup at all, I think it is required
 for certain browsers that don't trigger 'input' - @azaozz would probably
 know for sure :)
 * two events triggered the `search` event - hitting enter and changing the
 type dropdown. I changed both of these to trigger `input` instead
 * when changing the dropdown, we should trigger the search again even if
 the search field string hasn't changed, I updated the logic to ensure that
 works

 I noticed that we are triggering a search when the field is blank, for
 example changing the dropdown or hitting the escape button. This shows all
 plugins and seems unexpected. Do you think we should avoid searching when
 the search field is blank?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37233#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform