[wp-trac] [WordPress Trac] #37383: Theme browser keyboard traps

[WordPress Trac]

#37383: Theme browser keyboard traps
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Themes                   |     Version:  3.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch commit                       |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots needs-patch => has-screenshots has-patch
               commit


Comment:

 [attachment:37383.diff] improves the `containFocus()` function to always
 get the correct first and last focusable elements, even when the theme
 browser displays the active theme details (in this case additional links
 are displayed).

 Also, reduces the `500ms` delay for setting the initial focus to `100ms`.
 I guess it could be also '0', as far as I see it just needs to guarantee
 `containFocus()` runs after the rendering has completed.

 Lastly, when on the first and last themes, adds a `disabled` attribute on
 the previous and next theme buttons since right now they just ''look''
 disabled but they're still focusable.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37383#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform