[wp-trac] [WordPress Trac] #37205: Shared term's edit screen is inaccessible
WordPress Trac
noreply at wordpress.org
Thu Jul 14 14:29:00 UTC 2016
#37205: Shared term's edit screen is inaccessible
------------------------------------+-----------------------------
Reporter: dlh | Owner: boonebgorges
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 4.6
Component: Taxonomy | Version: 4.5
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: administration
------------------------------------+-----------------------------
Changes (by boonebgorges):
* keywords: has-patch => has-patch dev-feedback
* milestone: Awaiting Review => 4.6
Comment:
Thinking through this issue. `$taxnow` was removed from the call to
`get_term()` in term.php in [36874]. The commit message suggests that the
taxonomy context should be set in `WP_Screen`, but I don't fully
understand how this is the case - `get_term()` doesn't reference the
current screen anywhere.
The fix suggested in [attachment:37205.2.diff] (which is too verbose -
`$taxnow` falls back on 'post_tag', so is never empty) depends on the
`?taxonomy` query arg being set when visiting term.php. This is in fact
the case when coming from edit-tags.php, which I think is the main path
into term.php.
Passing `$taxnow` into `get_term()` seems harmless as far as I can see,
but I'd like a confirmation from @swissspidy (author of [36874]) before
going forward with it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37205#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list