[wp-trac] [WordPress Trac] #37267: Don't output a cancel comment reply link if comments aren't threaded

WordPress Trac noreply at wordpress.org
Thu Jul 14 03:30:30 UTC 2016


#37267: Don't output a cancel comment reply link if comments aren't threaded
--------------------------+-----------------------------
 Reporter:  henry.wright  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Comments      |     Version:  2.9
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------------
Changes (by rachelbaker):

 * keywords:   => needs-patch
 * version:  4.5.3 => 2.9
 * component:  General => Comments
 * milestone:  Awaiting Review => Future Release


Comment:

 @henry.wright Thanks for the report.  While `cancel_comment_reply_link()`
 is always called, if you look at the code in
 `get_cancel_comment_reply_link()` the reply link is still output, but
 hidden unless the `replytocom` param is set:

 {{{#!php
 $style = isset($_GET['replytocom']) ? '' : ' style="display:none;"';
 }}}

 If threaded comments aren't allowed, I don't see why we need to output
 anything.  Would you be willing to submit a patch?

 Introduced in [12810]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37267#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list