[wp-trac] [WordPress Trac] #37290: Shiny Updates: Different strings for plugins and themes?
WordPress Trac
noreply at wordpress.org
Tue Jul 12 19:18:34 UTC 2016
#37290: Shiny Updates: Different strings for plugins and themes?
-------------------------------------+----------------------------
Reporter: pavelevap | Owner: swissspidy
Type: defect (bug) | Status: assigned
Priority: high | Milestone: 4.6
Component: Upgrade/Install | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: accessibility
-------------------------------------+----------------------------
Comment (by afercia):
Replying to [comment:16 swissspidy]:
> @afercia I added these in [attachment:37290.4.diff]. Does that work?
@swissspidy looks good to me! Maybe just check a translators comment `/*
translators: %s: Theme name */` in `script-loader.php` that seems a
leftover.
> Theoretically we could add those attributes to other links as well, but
I didn't want to go down that rabbit hole…
Maybe better to wait for i18n via JS? Otherwise I'm afraid the amount of
code necessary would grow insanely.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37290#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list