[wp-trac] [WordPress Trac] #37240: Remove schemes from dns-prefetch resource hint outputs

WordPress Trac noreply at wordpress.org
Tue Jul 12 00:53:09 UTC 2016


#37240: Remove schemes from dns-prefetch resource hint outputs
---------------------------------------------+-----------------------------
 Reporter:  niallkennedy                     |       Owner:  voldemortensen
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  4.6
Component:  General                          |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  performance
---------------------------------------------+-----------------------------

Comment (by niallkennedy):

 diff 2 is an improvement avoiding duplication.

 The `$urls` value is reused but bad values might not be removed during the
 first for loop. If the result of `esc_url` returns an empty string or if
 the host value of the parsed URL is empty then the array value should not
 be output.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37240#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list