[wp-trac] [WordPress Trac] #35191: Remove title attributes: the Tools > Import screen
WordPress Trac
noreply at wordpress.org
Mon Jul 11 23:23:17 UTC 2016
#35191: Remove title attributes: the Tools > Import screen
-------------------------------------------------+-------------------------
Reporter: afercia | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.6
Component: Import | Version: 4.4
Severity: normal | Resolution:
Keywords: has-screenshots has-patch needs- | Focuses: ui,
refresh | accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):
* keywords: has-screenshots has-patch => has-screenshots has-patch needs-
refresh
Comment:
Okay, can't upload a new patch due to continuous "database is locked"
errors on Trac. Will comment and try again tomorrow.
Thanks @swissspidy nice touch! Noticed a few issues, the most important
about the "Details" link introduced in the previous patch. When an
importer is installed and active, the plugin slug is missing from its data
so the Details link will be wrong. This is caused by the previous loop
that builds the `$importers` array and just skips the already installed
importers. As far as I see there are two options:
- don't display the "Details" link when an importer in installed and
active
- always set the plugin slug in the previous loop before the two
`continue`
I'd be fine with the former but would appreciate any feedback. Also, fixed
a couple of typos and simplified the links and status text.
Not sure about the changes in `pluggable.php` cc @swissspidy
About the visual part, tried a couple of different options. Worth
considering the "status text" could also be completely removed. Just let
me know and sorry if the screenshot are a bit big as file size.
I'd recommend to open new, separate, tickets for shininess and further
accessibility improvements (aria-labels, etc.) since we're already far
beyond the scope of this ticket :)
[[Image(https://cldup.com/GflzSuTnE0.png)]]
[[Image(https://cldup.com/GHcoPCWKmt.png)]]
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35191#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list