[wp-trac] [WordPress Trac] #37233: Shiny Updates: "Add New Plugin" shiny search issues

[WordPress Trac]

#37233: Shiny Updates: "Add New Plugin" shiny search issues
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  swissspidy
     Type:  defect (bug)             |      Status:  assigned
 Priority:  high                     |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  needs-patch has-         |     Focuses:  ui, accessibility,
  screenshots shiny-updates          |  javascript
-------------------------------------+-------------------------------------

Comment (by swissspidy):

 > For completeness, just wanted to mention that on 4.5 it is also possible
 to search plugins by author and by tag. Though this functionality has
 always been a bit hidden, it is now completely missing. The small select
 with the search type options appears just after forcing a page refresh.

 So on 4.5 that drop down is only shown after the first search, like on the
 plugin directory. On the new plugin directory, this drop down is currently
 completely missing.

 Only displaying it after the first search seems a bit weird (and confusing
 to users) when performing an Ajax search. I mean, suddenly a drop down
 pops up. How would you announce this to screen readers? Would you put
 focus on it?

 I think we should either always show this drop down or completely remove
 it. It's coupled to the `install_search_form()` function though. From the
 source code:

 {{{#!php
 // assume no $type_selector means it's a simplified search form
 }}}

 {{{#!php
 <?php if ( $type_selector ) : ?>
 <select name="type" id="typeselector">
 …
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37233#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform