[wp-trac] [WordPress Trac] #37257: Minor CSS fix on ".nav-tab-wrapper" class

WordPress Trac noreply at wordpress.org
Sun Jul 10 13:47:01 UTC 2016


#37257: Minor CSS fix on ".nav-tab-wrapper" class
--------------------------+---------------------------------
 Reporter:  ramiy         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Plugins       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui, administration
--------------------------+---------------------------------

Comment (by afercia):

 Replying to [comment:1 ramiy]:
 > The attached patch fixes the issue. It was tested on plugins, and on the
 About Page, verifying
 [https://core.trac.wordpress.org/ticket/33559#comment:18 this issue on
 ticket #33559] won't happen again.

 While I agree that it would be nice to don't use type selectors (h1,
 h2...), my concern is about backwards compatibility. There's the need of
 selectors with higher specificity to override `.wrap > h2:first-child`
 because there are still plugins that use the "navigation tabs" as a
 `.wrap` first-child H2 heading and in this case, as far as I see,
 [https://core.trac.wordpress.org/ticket/33559#comment:18 the issue on
 ticket #33559] still happens. Maybe trying to use just `.nav-tab-wrapper`
 and keep `.wrap h2.nav-tab-wrapper` could work? (would need some testing
 with various plugins)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37257#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list