[wp-trac] [WordPress Trac] #30575: Twenty Fourteen: Submenu items on dropdown menus nearly impossible to select on some Android mobile tablets

[WordPress Trac]

#30575: Twenty Fourteen: Submenu items on dropdown menus nearly impossible to
select on some Android mobile tablets
-------------------------------------+-----------------------------
 Reporter:  zoonini                  |       Owner:  davidakennedy
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Bundled Theme            |     Version:  4.0.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by davidakennedy):

 Hey @agkozak!

 Thanks for the work on the patch here. Much appreciated! Here's some
 feedback for you:

 Remove this from the comments:
 {{{
 * Modification of patch 30575 by Richard van Denderen
 * @link
 https://core.trac.wordpress.org/attachment/ticket/30575/30575.patch
 }}}

 You'd get props for this patch along with @rdd. No need to note it in the
 comments. Open source is collaborative by its very nature. :)

 On to more substantial patch feedback:

 * From an accessibility standpoint, it seems solid. I like the addition of
 the `aria-haspopup`, so nice work there.
 * I tested the patch on an iPad, which is the device I have, and it works
 well. One issue is that if you click/touch an item with a sub-menu and it
 opens, you cannot close it. Clicking on the `body` and/or outside the sub-
 menu won't close it and it hangs open so that's something we should
 refine. Twenty Sixteen does this. You can click outside of the sub-menu
 and it closes.
 * If you first load a page below the specified breakpoint for the mobile
 menu toggle, then resize the menu to a screen size above that breakpoint,
 the accessible focus styles (when tabbing through menus to display sub-
 menus) do not work. So it looks like the `.focus` class isn't applied.
 * The breakpoint in the CSS for the mobile menu toggle is `783px`. But in
 the JavaScript, it's `781`, so we should make that consistent.
 * It would be good to add a check at the beginning of the function to make
 sure the menu exist before going forward. It's possible child themes could
 not have a menu, and/or disable the fallback for custom menus.
 * We really need another tester to test this on some other devices once
 the patch is refined.

 Let me know if any of this doesn't make sense. Happy to test further and
 help out with the patch. Thanks again!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30575#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform