[wp-trac] [WordPress Trac] #37077: Replacing one variable handler for another to ensure proper conditional check occurs 100%.

[WordPress Trac]

#37077: Replacing one variable handler for another to ensure proper conditional
check occurs 100%.
--------------------------+------------------------------
 Reporter:  chadschulz    |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Formatting    |     Version:  4.5.2
 Severity:  trivial       |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------
Changes (by chadschulz):

 * component:  General => Formatting


Comment:

 Further reading reveals that HHVM may handle strict type checking
 differently than PHP. This could lead to occasional warnings when types
 aren't exactly as expected even if PHP under similar circumstances
 wouldn't throw any errors/warnings.

 Not sure if this changes anything as this particular conditional is
 looking to ween out any non-strings. And {{{!is_scalar()}}} is not
 specific enough (for either PHP or HHVM) while {{{!is_string()}}} does
 exactly what is required for {{{rawurlencode()}}}.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37077#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform