[wp-trac] [WordPress Trac] #36495: Standardize on 3-digit x.x style for _doing_it_wrong() and _deprecated_function() calls (was: Use 2-digit x.x style for _doing_it_wrong() and _deprecated_function() calls)

WordPress Trac noreply at wordpress.org
Wed Jul 6 12:18:26 UTC 2016


#36495: Standardize on 3-digit x.x style for _doing_it_wrong() and
_deprecated_function() calls
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  metodiew
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
Component:  General                              |  Release
 Severity:  trivial                              |     Version:
 Keywords:  good-first-bug has-patch needs-      |  Resolution:
  refresh                                        |     Focuses:  docs
-------------------------------------------------+-------------------------
Description changed by SergeyBiryukov:

Old description:

> We generally use 2-digit x.x style for `_doing_it_wrong()` calls, e.g.
> `'4.5'` instead if `'4.5.0'`.
>
> I've counted 5 instances of `'4.5.0'` being passed to `_doing_it_wrong()`
> and `_deprecated_function()`.

New description:

 ~~We generally use 2-digit x.x style for `_doing_it_wrong()` calls, e.g.
 `'4.5'` instead if `'4.5.0'.~~

 ~~I've counted 5 instances of `'4.5.0'` being passed to
 `_doing_it_wrong()` and `_deprecated_function()`.~~

 We use 3-digit x.x.x style for `@since`, per the
 [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/ documentation standards], however for
 `_doing_it_wrong()` and `_deprecated_*()`, 2-digit x.x style seems to
 prevail.

 We should standardize on 3-digit x.x.x style throughout core.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36495#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list