[wp-trac] [WordPress Trac] #37223: Fatal error when adding a new multi-site user due to incorrect error handling.

[WordPress Trac]

#37223: Fatal error when adding a new multi-site user due to incorrect error
handling.
------------------------------------------+------------------------
 Reporter:  pbogdan                       |       Owner:  flixos90
     Type:  defect (bug)                  |      Status:  assigned
 Priority:  normal                        |   Milestone:  4.6
Component:  Users                         |     Version:  4.5
 Severity:  major                         |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:  multisite
------------------------------------------+------------------------
Changes (by flixos90):

 * keywords:  needs-unit-tests has-patch => needs-unit-tests needs-patch
 * owner:   => flixos90
 * status:  new => assigned


Comment:

 Replying to [comment:3 deronimo]:
 > I created a pull request:
 > https://github.com/WordPress/WordPress/pull/221
 >
 > Does it address the issue?

 Thanks for the PR! However, it currently only masks your specific issue.
 As mentioned above, I think the problem here is that the conditionals are
 ordered wrong. Changing the `! is_wp_error( $new_user )` into
 `is_wp_error( $new_user )` should fix this problem. Would you mind
 creating a new patch for this?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37223#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform